[PATCH] D90690: [llvm-objcopy][MachO] Fix adding multiple sections

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/MachO/add-multiple-sections.test:3
+
+# RUN: yaml2obj %s -o %t
+# RUN: echo -n FOOabcdefg > %t.foo.data
----------------
MaskRay wrote:
> Drive-by: I think the test should be folded into add-section-64.test
I was thinking about it too and but now it seems to me that it would be better to keep this test separate.
That test (as well as add-section-32.test) verifies a number of things related to adding sections and I would prefer not to overload it further with extra logic. It makes things a bit easier to maintain.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90690/new/

https://reviews.llvm.org/D90690