[PATCH] D90644: [Legalizer][ARM][AArch64] Add legalizations for VECREDUCE_SEQ_FMUL

Tue Nov 3 14:11:26 PST 2020

cameron.mcinally added a comment.

In D90644#2372260 <https://reviews.llvm.org/D90644#2372260>, @cameron.mcinally wrote:

> In D90644#2372150 <https://reviews.llvm.org/D90644#2372150>, @nikic wrote:
>
>> - In llvm/test/CodeGen/ARM/vecreduce-fmul-legalization-strict.ll and llvm/test/CodeGen/AArch64/vecreduce-fmul-legalization-strict.ll, use 1.0 instead of 0.0 as the start value. That was probably a copy&paste mistake from fadds.
>
> That caught my eye too, but the 0.0 seemed okay since we can't peep this without NSZ (-0*0) and NNAN (0*NaN). Changing it to 1.0 isn't a big deal though...

Oh, I see it now. The 1.0 is the neutral element, so it folds. Makes sense now...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90644/new/

https://reviews.llvm.org/D90644