[PATCH] D90644: [Legalizer][ARM][AArch64] Add legalizations for VECREDUCE_SEQ_FMUL

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 13:07:37 PST 2020


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM

Before you land this, I would suggest to improve the test coverage a bit:

- In @llvm.vector.reduce.fmul.f128.v2f128, duplicate the tests without `fast`
- In llvm/test/CodeGen/ARM/vecreduce-fmul-legalization-strict.ll and llvm/test/CodeGen/AArch64/vecreduce-fmul-legalization-strict.ll, use 1.0 instead of 0.0 as the start value. That was probably a copy&paste mistake from fadds.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90644/new/

https://reviews.llvm.org/D90644



More information about the llvm-commits mailing list