[PATCH] D90511: [MC] Make MCStreamer aware of AsmParser's StartTokLoc

Tue Nov 3 12:37:55 PST 2020

MaskRay added a comment.

In D90511#2371912 <https://reviews.llvm.org/D90511#2371912>, @MaskRay wrote:

> In D90511#2371796 <https://reviews.llvm.org/D90511#2371796>, @vitalybuka wrote:
>
>> In D90511#2370287 <https://reviews.llvm.org/D90511#2370287>, @MaskRay wrote:
>>
>>> In D90511#2370257 <https://reviews.llvm.org/D90511#2370257>, @vitalybuka wrote:
>>>
>>>> Looks like http://lab.llvm.org:8011/#/builders/99/builds/397/steps/9/logs/stdio is caused by this
>>>
>>> It was an pre-existing problem which has been fixed by bc847b31435e48ad0e54b322a716a4b9f07bc232 <https://reviews.llvm.org/rGbc847b31435e48ad0e54b322a716a4b9f07bc232>
>>
>> It's still broken
>
> Did you mean http://lab.llvm.org:8011/#/builders/99/builds/422 ? I think it is due to a different patch. I am going to investigate it
>
>   Failed Tests (1):
>     Clang-Unit :: Tooling/./ToolingTests/TransformerTest.TemplateInstantiation
>   
>   ==51632==ERROR: AddressSanitizer: stack-use-after-return on address 0x7f0becfa8b00 at pc 0x00000ae0212e bp 0x7ffe5a83f8b0 sp 0x7ffe5a83f8a8
>   READ of size 8 at 0x7f0becfa8b00 thread T0
>       #0 0xae0212d in onStartOfTranslationUnit /b/sanitizer-x86_64-linux-bootstrap/build/llvm-project/clang/lib/ASTMatchers/ASTMatchFinder.cpp:391:11
>       #1 0xae0212d in clang::ast_matchers::MatchFinder::matchAST(clang::ASTContext&) /b/sanitizer-x86_64-linux-bootstrap/build/llvm-project/clang/lib/ASTMatchers/ASTMatchFinder.cpp:1234:11
>       #2 0xecb767e in clang::ParseAST(clang::Sema&, bool, bool) /b/sanitizer-x86_64-linux-bootstrap/build/llvm-project/clang/lib/Parse/ParseAST.cpp:171:13
>       #3 0xb3e7ab4 in clang::FrontendAction::Execute() /b/sanitizer-x86_64-linux-bootstrap/build/llvm-project/clang/lib/Frontend/FrontendAction.cpp:949:8
>   `

@vitalybuka Fixed `ASAN_OPTIONS=detect_stack_use_after_return=1 ..../tools/clang/unittests/Tooling/ToolingTests --gtest_filter='*TransformerTest.TemplateInstantiation'` in 96ed6793b35e8267b0c94ebe69ae94f07024f476 <https://reviews.llvm.org/rG96ed6793b35e8267b0c94ebe69ae94f07024f476>. The relevant code was last touched in 2019 so I wonder why it only failed recently...

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90511/new/

https://reviews.llvm.org/D90511