[PATCH] D90700: [scudo][standalone] Simplify populateFreelist

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 11:22:10 PST 2020


cryptoad created this revision.
cryptoad added reviewers: pcc, hctim, eugenis, cferris.
Herald added a project: Sanitizers.
Herald added a subscriber: Sanitizers.
cryptoad requested review of this revision.

`populateFreelist` was more complicated that it needed to be. We used
to call to `populateBatches` that would do some internal shuffling and
add pointers one by one to the batches, but ultimately this was not
needed. We can get rid of `populateBatches`, and do processing in
bulk. This doesn't necessarily make things faster as this is not on the
hot path, but it makes the function cleaner.

Additionally clean up a couple of items, like `UNLIKELY`s and setting
`Exhausted` to `false` which can't happen.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90700

Files:
  compiler-rt/lib/scudo/standalone/primary32.h
  compiler-rt/lib/scudo/standalone/primary64.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90700.302637.patch
Type: text/x-patch
Size: 8763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201103/e673ce92/attachment.bin>


More information about the llvm-commits mailing list