[PATCH] D89485: [MachineOutliner] Do not outline debug instructions

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

Can you reduce the contents of `f`, `g`, and `h` so that you only have

- The instructions which are outlined
- Debug instructions which should not be outlined

This will make the testcase a lot easier for people reading it to understand what's going on. It will also make it less likely for it to fail because of unrelated changes.



================
Comment at: llvm/test/CodeGen/ARM/machine-outliner-remove-debug-instr.mir:14
+--- |
+  source_filename = "x.ll"
+  target datalayout = "e-m:e-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64"
----------------
This part of the IR isn't necessary


================
Comment at: llvm/test/CodeGen/ARM/machine-outliner-remove-debug-instr.mir:15
+  source_filename = "x.ll"
+  target datalayout = "e-m:e-p:32:32-Fi8-i64:64-v128:64:128-a:0:32-n32-S64"
+
----------------
You can remove this part too


================
Comment at: llvm/test/CodeGen/ARM/machine-outliner-remove-debug-instr.mir:38
+---
+name:            h
+tracksRegLiveness: true
----------------
Is this function outlined from at all? Can it just be removed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89485/new/

https://reviews.llvm.org/D89485