[PATCH] D90680: [lld][ELF][test] test LTO-removed symbols are not in symtab

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 10:58:50 PST 2020


MaskRay added a comment.

Instead of keeping adding new tests for some specific properties, I find many times reusing the existing tests is more appropriate. (People studying the behavior can read one file instead of several files with the same structure  which just tests different properties). For this case the test can be added into `lto/internalize-basic.ll`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90680/new/

https://reviews.llvm.org/D90680



More information about the llvm-commits mailing list