[PATCH] D90688: [CaptureTracking] Avoid overly restrictive dominates check

Anna Thomas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 10:55:26 PST 2020


anna added a comment.

In D90688#2371455 <https://reviews.llvm.org/D90688#2371455>, @jdoerfert wrote:

> LGTM. Attributor does the same with an "optimistic" version of reachability via `AAReachability`. I guess that is why no test there changed.

Thanks Johannes. We see these limitations in clients that use this analysis downstream and I was surprised we didn't have a `TODO` testcase upstream either (i.e. no test cases failing).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90688/new/

https://reviews.llvm.org/D90688



More information about the llvm-commits mailing list