[PATCH] D72184: [WIP][BPF] support exchange/compare-and-exchange instruction

[Brendan Jackman via Phabricator via llvm-commits]

jackmanb added inline comments.


================
Comment at: llvm/lib/Target/BPF/BPFInstrFormats.td:98
+
+def BPF_ATOMIC_FETCH : BPFAtomicFlag<0x1>;
 
----------------
Per Alexei's email comments let's call this BPF_FETCH?


================
Comment at: llvm/lib/Target/BPF/BPFInstrInfo.td:765
+      def XCHGB : XCHG<BPF_B, "8", atomic_swap_8>;
+      def XCHGH : XCHG<BPF_H, "16", atomic_swap_16>;
+      def XCHGW : XCHG<BPF_W, "32", atomic_swap_32>;
----------------
I don't know if we want to define these for 16 and 8bit operands - XADD isn't defined for those.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72184/new/

https://reviews.llvm.org/D72184