[PATCH] D87697: Do not construct std::string from nullptr
Yuriy Chernyshov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 3 03:09:52 PST 2020
georgthegreat updated this revision to Diff 302529.
georgthegreat added a comment.
Restore unreachable return statement, upon mclow.lists@ request.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87697/new/
https://reviews.llvm.org/D87697
Files:
llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
Index: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
===================================================================
--- llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
+++ llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
@@ -1307,7 +1307,7 @@
return "u32";
}
llvm_unreachable("unexpected type");
- return nullptr;
+ return {};
}
void NVPTXAsmPrinter::emitPTXGlobalVariable(const GlobalVariable *GVar,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D87697.302529.patch
Type: text/x-patch
Size: 407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201103/9bcd58c4/attachment.bin>
More information about the llvm-commits
mailing list