[PATCH] D90610: [Inline] Fix in handling of ptrtoint in InlineCost
Mikael Holmén via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 3 00:10:51 PST 2020
uabelho added a comment.
In D90610#2368489 <https://reviews.llvm.org/D90610#2368489>, @mtrofin wrote:
> Thanks for looking into this!
>
> Should places where we use ConstantOffsetPtrs to determine if instructions may be simplified, like CallAnalyzer::visitCmpInst, be also adjusted? Or does the ContantExpr::getICmp call take care of different-sized constant ints?
I don't know. When I debugged PR49890 I just realized that the size mismatch was introduced with the ptrtoint, so I tried doing something about that instead of trying to handle it at every use of ConstantOffsetPtrs. And then I realized that fix seems to have fixed PR38500 as well.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90610/new/
https://reviews.llvm.org/D90610
More information about the llvm-commits
mailing list