[PATCH] D89855: [PowerPC] Extend folding RLWINM + RLWINM to post-RA.

[EsmeYi via Phabricator via llvm-commits]

Esme added a comment.

Thanks for your reviews, and I apologize for not responding in time.  I will commit this patch after all tests done.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrInfo.cpp:3355
+    // its flag is "killed", it's safe to delete SrcMI. Otherwise keep it.
+    if ((!MRI->isSSA() && NoUse) ||
+        (MRI->isSSA() && MRI->use_nodbg_empty(FoldingReg))) {
----------------
steven.zhang wrote:
> Can we set the NoUse for pre-ra also，so that just check the NoUse here？
For the scenario of pre-ra, we have to check `MRI->use_nodbg_empty(FoldingReg)` here instead of setting NoUse before folding as post-ra did, since `MRI->use_nodbg_empty(FoldingReg)` is false before folding MI and SrcMI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89855/new/

https://reviews.llvm.org/D89855