[PATCH] D89736: [ms] [llvm-ml] Implement the expression expansion operator

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

The diff looks like maybe there was a rebasing accident (?)



================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:3297
+    return parseAngleBracketString(Data);
+  case AsmToken::Identifier: {
+    StringRef ID;
----------------
This branch seems unrelated to this patch (?)


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:5554
+  SMLoc EndLoc = getTok().getLoc();
+  if (getTok().isNot(AsmToken::EndOfStatement) && parseTextItem(Value))
+    return Error(EndLoc,
----------------
also looks unrelated (?)


================
Comment at: llvm/lib/MC/MCParser/MasmParser.cpp:6035
+            "expected text item parameter for 'elseifidn' directive");
+      else
+        return TokError(
----------------
llvm code style says no else after return; lhs code was better


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89736/new/

https://reviews.llvm.org/D89736