[PATCH] D90299: [windows-itanium] handle dllimport/export code paths separately and share with PS4

[ben via Phabricator via llvm-commits]

bd1976llvm marked an inline comment as done.
bd1976llvm added inline comments.


================
Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:3201
     if (CGM.getVTables().isVTableExternal(RD))
-      return IsDLLImport && !CGM.getTriple().isWindowsItaniumEnvironment()
+      return IsDLLImport && !CGM.getTriple().isDLLImportExportMSCompatible()
                  ? false
----------------
rnk wrote:
> `CGM` also has a `getTarget()` method to get `TargetInfo` if the predicate moves there.
Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90299/new/

https://reviews.llvm.org/D90299