[PATCH] D89731: [ms] [llvm-ml] Lex MASM strings, including escaping
Nico Weber via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 2 16:13:20 PST 2020
thakis added a comment.
Herald added a subscriber: pengfei.
This is missing tests for almost all of the functionality added in this patch ('asdf''''jkl' -> `asdf''jkl` but "asdf''''jkl" -> `asdf''''jkl`, similar for with ' and " swapped, and the single-char case).
================
Comment at: llvm/lib/MC/MCParser/AsmLexer.cpp:596
if (CurChar == EOF)
return ReturnError(TokStart, "unterminated string constant");
+ } else {
----------------
put a `return AsmToken(AsmToken::String, StringRef(TokStart, CurPtr - TokStart));` here, and leave the rest of the function unmodified
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89731/new/
https://reviews.llvm.org/D89731
More information about the llvm-commits
mailing list