[PATCH] D83655: [AsmPrinter] Split up .gcc_except_table

Rahman Lavaee via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 14:31:09 PST 2020


rahmanl accepted this revision.
rahmanl added a comment.

In D83655#2369636 <https://reviews.llvm.org/D83655#2369636>, @MaskRay wrote:

> @rahmanl: @dblaikie and @jrtc27 prefer having a suffix to be consistent with .text.foo and .rodata.foo . On a second thought I think this indeed makes more sense. People who want to save .strtab space can use -fno-unique-section-names. Are you fine with the resolution?

Agreed.
In this case`-funique-section-names` is mandatory to ensure LSDA sections are separated when unique IDs cannot be used, and that is fine because `unique-section-names=true` is the default.

Thanks for making this patch a priority.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83655/new/

https://reviews.llvm.org/D83655



More information about the llvm-commits mailing list