[PATCH] D90578: [llvm] New worker for ThinLTO whole program devirtualization

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: buildbot/osuosl/master/config/builders.py:1069
+                        '-DCMAKE_C_FLAGS="-O3 -Xclang -fwhole-program-vtables -fno-split-lto-unit"',
+                        '-DCMAKE_EXE_LINKER_FLAGS="-Wl,--lto-whole-program-visibility"'])},
+
----------------
mtrofin wrote:
> tejohnson wrote:
> > mtrofin wrote:
> > > Consider adding -DLLVM_CCACHE_BUILD=ON, too, to speed up compilation. (ccache is installed on the bot, afaik)
> > I can do that. Do you know why this isn't just on by default for all bots? I checked and there's only a few that have it enabled.
> > 
> > I assume this helps only the first stage compile of a multi-stage build, since for the later stages the compiler will have changed?
> > I can do that. Do you know why this isn't just on by default for all bots? I checked and there's only a few that have it enabled.
> > 
> You need to have ccache installed, which is up to the bot administrator. We install it.
> 
> > I assume this helps only the first stage compile of a multi-stage build, since for the later stages the compiler will have changed?
> At minimum, yes.
> 
> 
> You need to have ccache installed, which is up to the bot administrator. We install it.

Got it, thanks.


Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90578/new/

https://reviews.llvm.org/D90578