[PATCH] D89847: [SCEV] Drop cached ranges of AddRecs after flag update

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:5360
+    UnsignedRanges.erase(AddRec);
+    SignedRanges.erase(AddRec);
+  }
----------------
mkazantsev wrote:
> nikic wrote:
> > Could it happen that other ranges have been computed in the meantime, based on the now outdated addrec range?
> Unfortunately yes. But tracking them would be expensive.
Agreed, I do not think tracking this would be feasible unfortunately, but missing updates should be fine, as this should only refine the flags.

Can we assert here that Flags is a refinement of the existing flags on the AddREc?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89847/new/

https://reviews.llvm.org/D89847