[PATCH] D90577: [WebAssembly] Don't fold frame offset for global addresses

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 13:34:29 PST 2020


dschuff added a comment.

I think in theory, we could actually keep this optimization if we had a (ULEB?) relocation type with an addend (I think R_WASM_MEMORY_ADDR_LEB would work, actually).
Then we'd emit a load with a reloc against its constant offset field, where the addend would be the frame offset and the symbol would be the operand (similarly to what `LadPatImmOff` does for ISel)?
Of course if nobody discovered this bug before now it might not be that worthwhile...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90577/new/

https://reviews.llvm.org/D90577



More information about the llvm-commits mailing list