[PATCH] D90421: [IndVarSimplify][LoopUtils] Move WidenIV to Utils. NFCI.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 13:32:51 PST 2020


fhahn added a reviewer: mkazantsev.
fhahn added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/LoopUtils.h:460
+
+class WidenIV {
+  // Parameters
----------------
If this must indeed be part of the header, this needs a doc-comment


================
Comment at: llvm/include/llvm/Transforms/Utils/LoopUtils.h:466
+  // Context
+  LoopInfo        *LI;
+  Loop            *L;
----------------
Does this all need to be part of the header? Or can we hide most of that in looputils.cpp and just expose a single function to do the widening?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90421/new/

https://reviews.llvm.org/D90421



More information about the llvm-commits mailing list