[PATCH] D90537: [GWP-ASan] Stub out backtrace/signal functions on Fuchsia

[Mitch Phillips via Phabricator via llvm-commits]

hctim accepted this revision.
hctim added a comment.

LGTM w/ nit.



================
Comment at: compiler-rt/lib/gwp_asan/optional/segv_handler_fuchsia.cpp:15
+namespace crash_handler {
+void installSignalHandlers(gwp_asan::GuardedPoolAllocator *GPA, Printf_t Printf,
+                           PrintBacktrace_t PrintBacktrace,
----------------
mcgrathr wrote:
> Another option is `[[maybe_unused]]` on each parameter.
Prefer

```
void installSignalHandlers(gwp_asan::GuardedPoolAllocator * /* GPA */, Printf_t /* Printf */,
                           PrintBacktrace_t /* PrintBacktrace */,
                           SegvBacktrace_t /* SegvBacktrace */) {
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90537/new/

https://reviews.llvm.org/D90537