[PATCH] D90608: [WebAssembly] Implement ref.null

[Thomas Lively via Phabricator via llvm-commits]

tlively added a comment.

Nice! This looks good besides that one question. Also, for the patch description, it seems slightly misleading to say that "the register form of ref.null is still unimplemented"; IIUC, the register form is implemented since the `I` tablegen multiclass creates both forms, but it's simply not used for anything right now.

Since this is your first LLVM patch, I assume you don't have commit access to LLVM yet? If so, I can land this for you. After a couple more patches, you should request commit access <https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access>.



================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:584
+          Parser.Lex();
+          ExpectHeapType = false;
         } else {
----------------
Is this last line necessary? It looks like the other cases don't have similar lines.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90608/new/

https://reviews.llvm.org/D90608