[PATCH] D90566: [LazyCallGraph] Build SCCs of the reference graph in order

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/test/Other/scc-pass-printer.ll:14
 
-; INL: IR Dump After {{Function Integration/Inlining|InlinerPass .*scc: .bar, foo}}
-; INL: define void @bar()
-; INL-NEXT:  call void @foo()
-; INL: define void @foo()
+; LEGACY: IR Dump After Function Integration/Inlining
+; LEGACY:        define void @bar()
----------------
MaskRay wrote:
> aeubanks wrote:
> > what's the reason for splitting the NPM and legacy PM RUN lines?
> The orders of bar and foo are different...
> 
> The legacy PM SCC is `bar,foo` and thus `llvm/lib/Analysis/CallGraphSCCPass.cpp` prints the functions in the (reversed) order.
Oh sorry I missed that, I thought the only change was the "bar, foo" -> "foo, bar".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90566/new/

https://reviews.llvm.org/D90566