[PATCH] D90631: [FileCheck] Use %ProtectFileCheckOutput in allow-unused-prefixes.txt

Mon Nov 2 10:41:11 PST 2020

mtrofin marked an inline comment as done.
mtrofin added a comment.

In D90631#2368920 <https://reviews.llvm.org/D90631#2368920>, @dblaikie wrote:

> I think only the FileCheck commands that are themselves FileChecked need the protection. The other ones are intended to be rendered to users (humans running the tests) so would benefit from being able to be customized with FILECHECK_OPTS, I think?

================
Comment at: llvm/test/FileCheck/allow-unused-prefixes.txt:3-7
+; RUN: %ProtectFileCheckOutput FileCheck --allow-unused-prefixes=true  --check-prefixes=P1,P2 --input-file %S/Inputs/one-check.txt %S/Inputs/one-check.txt 

 ;; Note: the default will be changed to 'false', at which time this run line
 ;; should be changed accordingly.
+; RUN: %ProtectFileCheckOutput FileCheck --check-prefixes=P1,P2 --input-file %S/Inputs/one-check.txt %S/Inputs/one-check.txt 
----------------
dblaikie wrote:
> I /think/ these two don't need it, since their output doesn't feed into another FileCheck command (so I assume it's intended to be seen/understood by a human) - but I haven't looked closely at the test. Is there some reason these two would need stabilized/non-customizable output?
What if the user sets --allow-unused-prefixes in their env?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90631/new/

https://reviews.llvm.org/D90631