[PATCH] D90621: [FileCheck] Added documentation for --allow-unused-prefixes

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 09:58:19 PST 2020


thopre added inline comments.


================
Comment at: llvm/docs/CommandGuide/FileCheck.rst:69-70
+
+ This option controls behavior when using more than one :option:`--check-prefix`
+ or the alias :option:`--check-prefixes` with multiple values, and some of these
+ prefixes are missing in the test file. If true, this is allowed, if false,
----------------
Nit: Although this is common sense, the phrasing doesn't look like it includes the case of one --check-prefix and one --check-prefixes with a single value. How about:

This option controls the behavior when using more than one prefix as specified by :option:`--check-prefix` or :option:`--check-prefixes` and some of these prefixes are missing in the test file.

Rest is fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90621/new/

https://reviews.llvm.org/D90621



More information about the llvm-commits mailing list