[PATCH] D83655: [AsmPrinter] Split up .gcc_except_table

[Rahman Lavaee via Phabricator via llvm-commits]

rahmanl added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:852
+  // Append the function name as the suffix like GCC. Note it is unclear whether
+  // -funique-section-names should apply to .gcc_except_table sections. If it
+  // applies, we can fold this case into the next one if SHF_LINK_ORDER is
----------------
You have a point here. Currently the help line for `-funique-section-names` says:
`-funique-section-names  Use unique names for text and data sections (ELF Only)`.

And I couldn't find a case where `getUniqueSectionNames()` is used for non-globals.

One thing I can suggest is not to gate on this flag and instead use the suffix whenever we can't use a unique ID. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83655/new/

https://reviews.llvm.org/D83655