[PATCH] D90623: AMDGPU/GlobalISel: Use same builder/observer in post-legalizer-combiner

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

Also see D81899 <https://reviews.llvm.org/D81899>



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:179
+void AMDGPUPostLegalizerCombinerHelper::applyUCharToFloat(MachineInstr &MI) {
+  B.setInstr(MI);
 
----------------
setInstrAndDebugLoc (we should really just fix this terrible API to make with-debug the normal case)


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:232
+    MachineInstr &MI, const CvtF32UByteMatchInfo &MatchInfo) {
+  B.setInstr(MI);
   unsigned NewOpc = AMDGPU::G_AMDGPU_CVT_F32_UBYTE0 + MatchInfo.ShiftOffset / 8;
----------------
AndDebugLoc


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90623/new/

https://reviews.llvm.org/D90623