[PATCH] D89395: [Flang][OpenMP 4.5] Add semantic check for OpenMP shared and private clause

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

LGTM. 
Please wait for approval from @clementval after uppercasing the clause names.



================
Comment at: flang/lib/Semantics/check-omp-structure.cpp:422
+}
+void OmpStructureChecker::CheckObjectListStructure(
+    const parser::OmpObjectList &objList) {
----------------
Nit: Would a better name be CheckIsVarPartOfAnotherVar?


================
Comment at: flang/lib/Semantics/check-omp-structure.h:165
 
-private:
+  void CheckObjectListStructure(const parser::OmpObjectList &objList);
 
----------------
Nit: Can this be private?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89395/new/

https://reviews.llvm.org/D89395