[PATCH] D89625: Add default value for MachineInstr::modifiesRegister. NFC.

Momchil Velikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 07:28:47 PST 2020


chill added a comment.

In D89625#2367785 <https://reviews.llvm.org/D89625#2367785>, @yroux wrote:

> I'd check if there are some calls of modifiesRegister that pass nullptr, the patch LGTM otherwise

AFAICT, there's one such call, in the Hexagon backend, but I don't think we should change it (or other places) to take advantage of the default value.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89625/new/

https://reviews.llvm.org/D89625



More information about the llvm-commits mailing list