[PATCH] D90223: [AMDGPU][GlobalISel] Combine shift + logic + shift with constant operands

[Jay Foad via Phabricator via llvm-commits]

foad accepted this revision.
foad added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:1611
+                                              ShiftOfShiftedLogic &MatchInfo) {
+  // We're trying to match the following pattern with any of G_SHL/G_ASHR/G_LSHR
+  // shift instructions in combination with any of G_AND/G_OR/G_XOR logic
----------------
foad wrote:
> Also handle G_USHLSAT and G_SSHLSAT?
Comment still needs updating.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90223/new/

https://reviews.llvm.org/D90223