[PATCH] D89777: [TableGen][SchedModels] Fix read/write variant substitution

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 02:19:15 PST 2020


dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

LGTM. Thanks for the update.



================
Comment at: llvm/utils/TableGen/CodeGenSchedule.cpp:1592
+    // Now expand each variant on top of its copy of the transition.
+    for (std::vector<TransVariant>::const_iterator
+             IVI = IntersectingVariants.begin(),
----------------
Perhaps now use a range based for, and no brackets.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89777/new/

https://reviews.llvm.org/D89777



More information about the llvm-commits mailing list