[PATCH] D90580: [RISCV] When matching RORIW, make sure the same input is given to both shifts.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 02:00:32 PST 2020


frasercrmck added a comment.

The comment at the top of `SelectRORIW` says

  //  (SIGN_EXTEND_INREG (OR (SHL (AsserSext RS1, i32), VC2),
  //                         (SRL (AND (AssertSext RS2, i32), VC3), VC1)))

should it make it apparent that RS1 must equal RS2?

LGTM otherwise.



================
Comment at: llvm/test/CodeGen/RISCV/rv64Zbbp.ll:346
 
 ; This test is similar to the type legalized versio of the fshl/fshr tests, but
 ; instead of having the same input to both shifts it has different inputs. Make
----------------
You could fix up the typo `versio` here, and `has a roriw` below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90580/new/

https://reviews.llvm.org/D90580



More information about the llvm-commits mailing list