[PATCH] D90576: [ADT] Add SmallVector::pop_back_n

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 1 17:41:54 PST 2020


dblaikie added a comment.

More expressive in what way(s)? I hesitate a little to add more surface area compared to the standard library as it adds a bit of friction when moving between different containers. (not an outright "never" but "might be a bit higher bar than it would otherwise be")
Could/should this use naming conventions from StringPiece? (there's various drop_n, etc)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90576/new/

https://reviews.llvm.org/D90576



More information about the llvm-commits mailing list