[PATCH] D90550: [Coroutines][Docs] Remove frame packing as a TODO
Atmn Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 1 03:52:30 PST 2020
atmnpatel created this revision.
atmnpatel added reviewers: rjmccall, majnemer, GorNishanov.
Herald added subscribers: llvm-commits, modocache.
Herald added a project: LLVM.
atmnpatel requested review of this revision.
This has already been done by @rjmccall in D76526 <https://reviews.llvm.org/D76526> (49e5a97ec363 <https://reviews.llvm.org/rG49e5a97ec363a844b167340a82b54a01dc4e671a>), and
9514c048d89e <https://reviews.llvm.org/rG9514c048d89e6aef82d86c3478223fcb28230a4f>. We should remove this from the docs.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D90550
Files:
llvm/docs/Coroutines.rst
Index: llvm/docs/Coroutines.rst
===================================================================
--- llvm/docs/Coroutines.rst
+++ llvm/docs/Coroutines.rst
@@ -1535,10 +1535,6 @@
Areas Requiring Attention
=========================
-#. A coroutine frame is bigger than it could be. Adding stack packing and stack
- coloring like optimization on the coroutine frame will result in tighter
- coroutine frames.
-
#. Take advantage of the lifetime intrinsics for the data that goes into the
coroutine frame. Leave lifetime intrinsics as is for the data that stays in
allocas.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90550.302136.patch
Type: text/x-patch
Size: 591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201101/ff7c82a2/attachment.bin>
More information about the llvm-commits
mailing list