[PATCH] D89574: [test][Inliner] Split inline-cost test files

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 31 23:49:02 PDT 2020


MaskRay added a comment.

In D89574#2366681 <https://reviews.llvm.org/D89574#2366681>, @aeubanks wrote:

> Ping.
> Would it be better to just split the test into multiple files instad of using split-file?

Apologize for the slow response. I think split-file is better than multiple files in this case, but I want to understand the deep issue here. It seems that ModuleToPostOrderCGSCCPassAdaptor has a reversed processing order if the functions are independent. This seems unfortunate as this can make all such kind of tests difficult to write.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89574/new/

https://reviews.llvm.org/D89574



More information about the llvm-commits mailing list