[PATCH] D88658: [AVR] Optimize the 16-bit NEGW pseudo instruction

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 31 22:16:44 PDT 2020


benshi001 added inline comments.


================
Comment at: llvm/lib/Target/AVR/AVRInstrInfo.td:747
+  // clr Rtmp
+  // sbc Rtmp, Rd+1
+  def NEGWRd : Pseudo<(outs DREGS:$rd),
----------------
aykevl wrote:
> Is this correct? I only see one `neg` while both avr-gcc (https://godbolt.org/z/hETcE9) and the code in AVRExpandPseudoInsts.cpp seem to suggest two `neg` instructions are needed.
This is a previous typo, thanks. Already fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88658/new/

https://reviews.llvm.org/D88658



More information about the llvm-commits mailing list