[PATCH] D90324: [Flang][OpenMP][NFC][1/2] Reorder OmpStructureChecker and simplify it.

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 31 12:17:15 PDT 2020


clementval added a comment.

> So the macros are somewhat partial checks, having macros makes us easily figure out in this case whether the restrictions on clause are partially implemented or more detailed.

I don't fully agree on this one. At least on the OpenACC side lots of clauses will have only those checks and thus keep the macro or TableGen style.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90324/new/

https://reviews.llvm.org/D90324



More information about the llvm-commits mailing list