[lld] 32cc962 - [COFF] Move ghash timers under the "add objects" timer

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 31 11:20:13 PDT 2020


Author: Reid Kleckner
Date: 2020-10-31T11:08:59-07:00
New Revision: 32cc962ef35b94d24de188b7abfff9a9e2d74a6f

URL: https://github.com/llvm/llvm-project/commit/32cc962ef35b94d24de188b7abfff9a9e2d74a6f
DIFF: https://github.com/llvm/llvm-project/commit/32cc962ef35b94d24de188b7abfff9a9e2d74a6f.diff

LOG: [COFF] Move ghash timers under the "add objects" timer

I had envisioned the ghash step as a big up front step, but as currently
written, the timers are nested, and we are notionally adding types from
objects, so we might as well arrange the timers this way.

Added: 
    

Modified: 
    lld/COFF/PDB.cpp

Removed: 
    


################################################################################
diff  --git a/lld/COFF/PDB.cpp b/lld/COFF/PDB.cpp
index 846d7a11fbfa..5e65eca5b9fe 100644
--- a/lld/COFF/PDB.cpp
+++ b/lld/COFF/PDB.cpp
@@ -66,9 +66,9 @@ using llvm::object::coff_section;
 static ExitOnError exitOnErr;
 
 static Timer totalPdbLinkTimer("PDB Emission (Cumulative)", Timer::root());
-Timer lld::coff::loadGHashTimer("Global Type Hashing", totalPdbLinkTimer);
-Timer lld::coff::mergeGHashTimer("GHash Type Merging", totalPdbLinkTimer);
 static Timer addObjectsTimer("Add Objects", totalPdbLinkTimer);
+Timer lld::coff::loadGHashTimer("Global Type Hashing", addObjectsTimer);
+Timer lld::coff::mergeGHashTimer("GHash Type Merging", addObjectsTimer);
 static Timer typeMergingTimer("Type Merging", addObjectsTimer);
 static Timer symbolMergingTimer("Symbol Merging", addObjectsTimer);
 static Timer publicsLayoutTimer("Publics Stream Layout", totalPdbLinkTimer);


        


More information about the llvm-commits mailing list