[llvm] bd76f37 - [Bitcode] Make some basic PlaceholderQueue/MetadataLoaderImpl helper methods const. NFCI.

[Simon Pilgrim via llvm-commits]

Author: Simon Pilgrim
Date: 2020-10-31T12:16:48Z
New Revision: bd76f3724dd637da79e09ccd0a61a94b0d6d9d87

URL: https://github.com/llvm/llvm-project/commit/bd76f3724dd637da79e09ccd0a61a94b0d6d9d87
DIFF: https://github.com/llvm/llvm-project/commit/bd76f3724dd637da79e09ccd0a61a94b0d6d9d87.diff

LOG: [Bitcode] Make some basic PlaceholderQueue/MetadataLoaderImpl helper methods const. NFCI.

Fixes a number of cppcheck remarks.

Added: 
    

Modified: 
    llvm/lib/Bitcode/Reader/MetadataLoader.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Bitcode/Reader/MetadataLoader.cpp b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp
index 79aee0d52987..3fc85b122fa8 100644
--- a/llvm/lib/Bitcode/Reader/MetadataLoader.cpp
+++ b/llvm/lib/Bitcode/Reader/MetadataLoader.cpp
@@ -365,7 +365,7 @@ class PlaceholderQueue {
   ~PlaceholderQueue() {
     assert(empty() && "PlaceholderQueue hasn't been flushed before being destroyed");
   }
-  bool empty() { return PHs.empty(); }
+  bool empty() const { return PHs.empty(); }
   DistinctMDOperandPlaceholder &getPlaceholderOp(unsigned ID);
   void flush(BitcodeReaderMetadataList &MetadataList);
 
@@ -676,7 +676,7 @@ class MetadataLoader::MetadataLoaderImpl {
     return FunctionsWithSPs.lookup(F);
   }
 
-  bool hasSeenOldLoopTags() { return HasSeenOldLoopTags; }
+  bool hasSeenOldLoopTags() const { return HasSeenOldLoopTags; }
 
   Error parseMetadataAttachment(
       Function &F, const SmallVectorImpl<Instruction *> &InstructionList);
@@ -684,7 +684,7 @@ class MetadataLoader::MetadataLoaderImpl {
   Error parseMetadataKinds();
 
   void setStripTBAA(bool Value) { StripTBAA = Value; }
-  bool isStrippingTBAA() { return StripTBAA; }
+  bool isStrippingTBAA() const { return StripTBAA; }
 
   unsigned size() const { return MetadataList.size(); }
   void shrinkTo(unsigned N) { MetadataList.shrinkTo(N); }