[PATCH] D90469: [TableGen] Add !adjoin operator to adjoin a list of values with delimiters

[Paul C. Anagnostopoulos via Phabricator via llvm-commits]

Paul-C-Anagnostopoulos added a comment.

I wouldn't use !interleave. That sounds like it is doing something with multiple lists. Another choice was !listify, but that sounds like it would construct a list.

One possibility is !delimconcat.



================
Comment at: llvm/include/llvm/TableGen/Record.h:812
   enum BinaryOp : uint8_t { ADD, SUB, MUL, AND, OR, XOR, SHL, SRA, SRL, LISTCONCAT,
-                            LISTSPLAT, STRCONCAT, CONCAT, EQ, NE, LE, LT, GE,
+                            LISTSPLAT, STRCONCAT, ADJOIN, CONCAT, EQ, NE, LE, LT, GE,
                             GT, SETDAGOP };
----------------
jpienaar wrote:
> OOC what is the ordering here?
I've pondered the ordering of various lists in TableGen and the best I can come up with is that they are grouped logically. Do you think I should alphabetize this list?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90469/new/

https://reviews.llvm.org/D90469