[PATCH] D90104: [LoopUnroll] Duplicate noalias metadata

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 31 04:06:42 PDT 2020


nikic added a comment.

I've now updated this to introduce a common utility (ScopedAliasMetadataCloner) that can handle essentially the same task in inlining and loop unrolling. If that looks reasonable, I can commit the utility separately from the new usage in LoopUnroll.

@jeroen.dobbelaere: Yeah, I'm aware of that. However, the full restrict patches are a large change that has stalled for a long time, so I think we need to address the miscomples in a simple way in the meantime. I was also wondering if it might not make sense to split up the full restrict patches in a way that addresses individual problems without having to land the full machinery in one go. For example, by first introducing the noalias.decl function only, which is I believe the only part that's relevant for this particular problem.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90104/new/

https://reviews.llvm.org/D90104



More information about the llvm-commits mailing list