[PATCH] D83655: [AsmPrinter] Split up .gcc_except_table

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

I wonder if it'd be nicer to push this logic into getLSDASection by passing an (optional?) Function given that's where the normal LSDASection gets created? Having the check for ELF here seems to indicate that the logic isn't quite in the right place and belongs in the MCOFI subclass.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/EHStreamer.cpp:469
+      const MCSymbolELF *LinkedToSym = nullptr;
+      unsigned Flags = ELF::SHF_ALLOC;
+      StringRef Group;
----------------
Should this instead inherit the (base) flags from LSDASection? For CHERI we have to add SHF_WRITE (we make it a relro section) so it'd be nice to inherit that automatically here rather than needing to have the logic duplicated between here and initELFMCObjectFileInfo.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83655/new/

https://reviews.llvm.org/D83655