[PATCH] D90511: [MC] Make MCStreamer aware of AsmParser's StartTokLoc

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 16:32:27 PDT 2020


MaskRay added a comment.

In D90511#2365945 <https://reviews.llvm.org/D90511#2365945>, @arichardson wrote:

> This seems like a good solution to the problem I'm trying to fix in D89787 <https://reviews.llvm.org/D89787> and I'll rebase on top of this. Not sure about the name `StartTokLocPtr` though. Maybe `CurrentParserLoc`?

AsmParser.cpp:1919 has a variable called `StartTokLoc`. I felt the usage is similar so I picked it. We store the location of the starting token, instead of the current token, so `CurrentParserLoc` might be inappropriate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90511/new/

https://reviews.llvm.org/D90511



More information about the llvm-commits mailing list