[PATCH] D89921: [LLD] [COFF] Align all debug directories
Petr Penzin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 30 16:31:51 PDT 2020
penzn added a comment.
I think it works. We can keep "less than 4" check or keep it as is.
================
Comment at: lld/COFF/Writer.cpp:988
+ for (std::pair<COFF::DebugType, Chunk *> r : debugRecords) {
+ r.second->setAlignment(4);
+ debugInfoSec->addChunk(r.second);
----------------
Do we need "less than four" check? To be honest, I've lifted that from `createGuardCFTable`, and either way wold work for the issue we are fixing. I don't think `/align` flag would affect the alignment on this level.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89921/new/
https://reviews.llvm.org/D89921
More information about the llvm-commits
mailing list