[PATCH] D90511: [MC] Make MCStreamer aware of AsmParser's StartTokLoc

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added a reviewer: rnk.
Herald added subscribers: llvm-commits, gbedwell, hiraditya, sbc100, emaste.
Herald added a reviewer: espindola.
Herald added a reviewer: andreadb.
Herald added a project: LLVM.
MaskRay requested review of this revision.
Herald added a subscriber: aheejin.

A SMLoc allows MCStreamer to report location-aware diagnostics, which
were previously by adding SMLoc to various methods in an ad-hoc way.

Since the file:line is most important, the column is less important and
the start token location suffices in many cases, this patch reverts
b7e7131af2dd7bdb03fa42a3bc1b4bc72ab95ce1 <https://reviews.llvm.org/rGb7e7131af2dd7bdb03fa42a3bc1b4bc72ab95ce1>

  // old
  symbol-binding-changed.s:6:8: error: local changed binding to STB_GLOBAL
  .globl local
         ^
  // new
  symbol-binding-changed.s:6:1: error: local changed binding to STB_GLOBAL
  .globl local
  ^


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D90511

Files:
  llvm/include/llvm/MC/MCELFStreamer.h
  llvm/include/llvm/MC/MCStreamer.h
  llvm/include/llvm/MC/MCWasmStreamer.h
  llvm/include/llvm/MC/MCWinCOFFStreamer.h
  llvm/include/llvm/MC/MCXCOFFStreamer.h
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCELFStreamer.cpp
  llvm/lib/MC/MCMachOStreamer.cpp
  llvm/lib/MC/MCNullStreamer.cpp
  llvm/lib/MC/MCParser/AsmParser.cpp
  llvm/lib/MC/MCParser/ELFAsmParser.cpp
  llvm/lib/MC/MCWasmStreamer.cpp
  llvm/lib/MC/MCWinCOFFStreamer.cpp
  llvm/lib/MC/MCXCOFFStreamer.cpp
  llvm/lib/Object/RecordStreamer.cpp
  llvm/lib/Object/RecordStreamer.h
  llvm/test/MC/ELF/symbol-binding-changed.s
  llvm/tools/llvm-exegesis/lib/SnippetFile.cpp
  llvm/tools/llvm-mca/CodeRegionGenerator.cpp
  llvm/unittests/CodeGen/TestAsmPrinter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D90511.302036.patch
Type: text/x-patch
Size: 18574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20201030/8fb77367/attachment.bin>