[PATCH] D90503: [WebAssembly] Fixed DWARF DW_AT_low_pc encoded as 64-bit in wasm64

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

LGTM for now.
As I said, I have a feeling we may need to do something more to get the data address space right. But this is fine to avoid crashing.



================
Comment at: llvm/test/MC/WebAssembly/dwarfdump64.ll:1
+; RUN: llc -filetype=obj %s -o - | llvm-dwarfdump - | FileCheck %s
+
----------------
It might make sense to use the dwarfdump argument `--show-form` for this test, then we can see which attributes have addr vs other forms.


================
Comment at: llvm/test/MC/WebAssembly/dwarfdump64.ll:38
+; CHECK-NEXT:                DW_AT_decl_line	(5)
+; CHECK-NEXT:                DW_AT_location	(DW_OP_addr 0x8)
+
----------------
I have a feeling that this is probably wrong (i.e. it's 4 instead of 8). Maybe we should put a TODO here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90503/new/

https://reviews.llvm.org/D90503