[PATCH] D89787: [AsmParser] Add source location to all errors related to .cfi directives

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 15:13:32 PDT 2020


rnk added a comment.

I've been thinking about this problem of missing SMLocs for a while, and I think the right direction is probably for MCStreamer to have a way to get the location of the beginning of the directive being processed. That would suffice for the majority of these `.cfi_*` directives. It would make it much easier to get error reporting right by default or to add in error reporting later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89787/new/

https://reviews.llvm.org/D89787



More information about the llvm-commits mailing list