[PATCH] D89969: [SLP] Consider alternatives for cost of select instructions.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 30 14:27:44 PDT 2020


fhahn added a comment.

Interesting, thanks for sharing! I reverted the patch while I investigate.



================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:5991
+  // instructions is not done by SLPVectorizer and needs to be done by the
+  // backend.
+  // TODO: Support floating point min/max.
----------------
RKSimon wrote:
> Update the comment?
Thanks, I updated this in the committed version.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89969/new/

https://reviews.llvm.org/D89969



More information about the llvm-commits mailing list