[PATCH] D90426: hwasan: Support for outlined checks in the Linux kernel.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 30 12:42:45 PDT 2020
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:510
+ HasMatchAllTag = true;
+ MatchAllTag = ClMatchAllTag;
+ }
----------------
pcc wrote:
> eugenis wrote:
> > ClMatchTag & 0xF
> > either here or when constructing AccessInfo
> You mean `ClMatchAllTag & 0xFF`, right? This isn't MTE :)
>
> It is unnecessary because the field is a uint8_t but I suppose we could avoid an implicit truncation that way.
Right, I missed that. I was concerned about overwriting other fields of AccessInfo if the tag value is too large.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90426/new/
https://reviews.llvm.org/D90426
More information about the llvm-commits
mailing list