[PATCH] D89834: FileManager: Improve the FileEntryRef API and customize its OptionalStorage

[Daniel Kiss via Phabricator via llvm-commits]

danielkiss added inline comments.
Herald added a subscriber: ormris.


================
Comment at: clang/include/clang/Basic/FileEntry.h:186
+
+  constexpr bool hasValue() const noexcept {
+    return MaybeRef.hasOptionalValue();
----------------
This broke the build, `constexpr` could be dropped IMHO.
FileEntry.h(186):  error C3615: constexpr function 'llvm::optional_detail::OptionalStorage<clang::FileEntryRef,true>::hasValue' cannot result in a constant expression
FileEntry.h(187): note: failure was caused by call of undefined function or one not declared 'constexpr'
FileEntry.h(187): note: see usage of 'clang::FileEntryRef::hasOptionalValue'


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D89834/new/

https://reviews.llvm.org/D89834